Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lb_loadbalancer_v2: Add availability_zone #1225

Merged
merged 1 commit into from
Apr 14, 2021
Merged

lb_loadbalancer_v2: Add availability_zone #1225

merged 1 commit into from
Apr 14, 2021

Conversation

nikParasyr
Copy link
Member

@nikParasyr nikParasyr commented Apr 9, 2021 •
edited
Loading

Add availability_zone attribute to loadbalancer_v2

Close #1090

@nikParasyr
Copy link
Member Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 9, 2021

Build failed.

@nikParasyr
Copy link
Member Author

recheck lbaas

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 10, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 10, 2021

Build succeeded.

@nikParasyr
Copy link
Member Author

@ozerovandrei This is ready from my side. A couple of notes:

  • I had to remove the chooseLBV2LoadBalancerCreateOpts helper function and move the logic within the create func. Reason was that the return was of type neutronloadbalancers.CreateOptsBuilder and it was barking as AvailabilityZone is not part of it. I can create 2 helper functions if you prefer it that way
  • I haven't updated the tests as it is quite hard. It requires a nova aggregate with az, an octavia az-profile and then an octavia az. We don't have resources for most of these.

@nikParasyr nikParasyr marked this pull request as ready for review April 11, 2021 10:42
@nikParasyr
Copy link
Member Author

recheck

@nikParasyr nikParasyr mentioned this pull request Apr 12, 2021
Closed
@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 12, 2021

Build succeeded.

ozerovandrei
ozerovandrei approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@ozerovandrei ozerovandrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit 6d935c6 into terraform-provider-openstack:main Apr 14, 2021
@nikParasyr nikParasyr deleted the lb_az branch April 14, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozerovandrei ozerovandrei ozerovandrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port_id and availability_zone arguments on openstack_lb_loadbalancer_v2 resource
2 participants
@nikParasyr @ozerovandrei